[webkit-changes] [WebKit/WebKit] f9d7fe: Simplify GPUExternalTexture WebCodecsVideoFrame im...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9d7fea52f903441640365484bf48dc5d50d82ff
      https://github.com/WebKit/WebKit/commit/f9d7fea52f903441640365484bf48dc5d50d82ff
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h
    M Source/WebCore/platform/VideoFrame.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Shared/WebGPU/WebGPUConvertFromBackingContext.h
    M Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.cpp
    M Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.h
    M Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.serialization.in
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
    M Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp
    M Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h
    M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp

  Log Message:
  -----------
  Simplify GPUExternalTexture WebCodecsVideoFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=257724
<radar://110274148>

Reviewed by Kimmo Kinnunen.

Address feedback from #14055

Specifically in this patch we no longer pass the identifier + version manually
from the WebProcess to GPUProcess, instead SharedFrameVideoReader/Writer are used instead.

Also some stylistic feedback addressed.

Testing covered by GPUExternalTexture CTS tests.

* Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h:
(WebCore::GPUExternalTextureDescriptor::mediaIdentifierForSource):
(WebCore::GPUExternalTextureDescriptor::convertToBacking const):

* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h:
* Source/WebCore/platform/VideoFrame.h:
(WebCore::VideoFrame::pixelBuffer const):
(WebCore::VideoFrame::resourceIdentifier const): Deleted.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::importExternalTextureFromVideoFrame):
(WebKit::RemoteDevice::importExternalTexture): Deleted.
(WebKit::RemoteDevice::importExternalTextureFromPixelBuffer): Deleted.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in:
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_must_be_moved):
(headers_for_type):

* Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.h:
* Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::importExternalTexture):

* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
* Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
(WebKit::RemoteVideoFrameProxy::pixelBuffer const):
(WebKit::RemoteVideoFrameProxy::resourceIdentifier const): Deleted.

 Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h:
* Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::videoFrameAvailable):

Canonical link: https://commits.webkit.org/268232@main