[webkit-changes] [WebKit/WebKit] c0a9a9: jquery/attributes.html is flaky fail with StreamCl...
Kimmo Kinnunen
noreply at github.com
Mon Sep 18 10:31:08 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c0a9a955b480bb69772ceccfa2eca68906532e7f
https://github.com/WebKit/WebKit/commit/c0a9a955b480bb69772ceccfa2eca68906532e7f
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2023-09-18 (Mon, 18 Sep 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/ipc/restrictedendpoints/allow-access-webGPU-expected.txt
M LayoutTests/ipc/restrictedendpoints/allow-access-webGPU.html
M LayoutTests/ipc/restrictedendpoints/deny-access-webGPU.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/resources/ipc.js
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/Shared/IPCTester.h
M Source/WebKit/Shared/IPCTester.messages.in
Log Message:
-----------
jquery/attributes.html is flaky fail with StreamClientConnection ASSERTION FAILED: !m_connection->isValid()
https://bugs.webkit.org/show_bug.cgi?id=261555
rdar://115494068
Reviewed by Antti Koivisto.
Fix two tests that create StreamClientConnection instances through
the JS IPC Testing API. The connections must be invalidated
if they are created.
Both allow and deny tests are run as normal JS business as usual, even
though the test runner automatically ends the deny test when GPUP
crashes. This means that the JS GC will clean up the stream connections
during the next tests, causing unrelated tests to fail with the
assertion.
Fix the allow test to actually test what it tests, e.g. to fail if
WebGPU is disabled.
* LayoutTests/ipc/restrictedendpoints/allow-access-webGPU-expected.txt:
* LayoutTests/ipc/restrictedendpoints/allow-access-webGPU.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-webGPU.html:
* LayoutTests/resources/ipc.js:
(randomID):
(asyncFlush):
(syncFlush): Deleted.
* Source/WebKit/Shared/IPCTester.cpp:
(WebKit::IPCTester::asyncPing):
(WebKit::IPCTester::syncPing):
* Source/WebKit/Shared/IPCTester.h:
* Source/WebKit/Shared/IPCTester.messages.in:
Canonical link: https://commits.webkit.org/268086@main
More information about the webkit-changes
mailing list