[webkit-changes] [WebKit/WebKit] ab8e3b: [GTK4] NativeWebWheelEvent crashes on wheel event ...

Claudio Saavedra noreply at github.com
Mon Sep 18 10:28:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab8e3bcac4804bcfb9af5394a962556985b3c201
      https://github.com/WebKit/WebKit/commit/ab8e3bcac4804bcfb9af5394a962556985b3c201
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/gtk/GtkUtilities.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.cpp

  Log Message:
  -----------
  [GTK4] NativeWebWheelEvent crashes on wheel event tests
https://bugs.webkit.org/show_bug.cgi?id=261674

Reviewed by Michael Catanzaro.

The GdkEvent API in GTK4 won't play ball when given a NULL event.
When synthesizing wheel events we might pass a NULL event to the
event factory, so make sure that the methods that call GDK API
on it are NULL-safe.

* Source/WebCore/platform/gtk/GtkUtilities.cpp:
(WebCore::wallTimeForEvent):
* Source/WebKit/Shared/gtk/WebEventFactory.cpp:
(WebKit::modifiersForEvent):

Canonical link: https://commits.webkit.org/268085@main




More information about the webkit-changes mailing list