[webkit-changes] [WebKit/WebKit] 48210b: Use 'ScrollSetting' enum in 'VTTRegion.idl' align ...

Sun Sep 10 06:06:44 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48210b2e0db44cf7b44187d06d30c805389b34a7
      https://github.com/WebKit/WebKit/commit/48210b2e0db44cf7b44187d06d30c805389b34a7
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-09-10 (Sun, 10 Sep 2023)

  Changed paths:
    M Source/WebCore/html/track/VTTRegion.cpp
    M Source/WebCore/html/track/VTTRegion.h
    M Source/WebCore/html/track/VTTRegion.idl

  Log Message:
  -----------
  Use 'ScrollSetting' enum in 'VTTRegion.idl' align with IDL Spec
https://bugs.webkit.org/show_bug.cgi?id=260766
rdar://114859668

Reviewed by Eric Carlson.

Implement the scroll IDL attribute using a ScrollSetting enum as
suggested by the WebVTT standard. And because m_scroll is now of that
type we can also remove isScrollingRegion().

There should be no behavioral changes so no tests.

* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::setScroll):
(WebCore::VTTRegion::parseSettingValue):
(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::startTimer):
(WebCore::VTTRegion::scroll const): Deleted.
* Source/WebCore/html/track/VTTRegion.h:
* Source/WebCore/html/track/VTTRegion.idl:

Canonical link: https://commits.webkit.org/267842@main