[webkit-changes] [WebKit/WebKit] bc6175: Correct URL encoding of fetch module

Anne van Kesteren noreply at github.com
Sun Sep 10 05:45:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc617596ba9a959266877894f24dbe9fe9f7c71b
      https://github.com/WebKit/WebKit/commit/bc617596ba9a959266877894f24dbe9fe9f7c71b
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-09-10 (Sun, 10 Sep 2023)

  Changed paths:
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.js
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.worker-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.js
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.serviceworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.worker-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-url-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.js
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.worker-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-others-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/text-utf8-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub.html
    A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=utf8-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=windows-1252-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=x-cp1251-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/w3c-import.log
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.worker-expected.txt
    M Source/WebCore/Modules/fetch/FetchRequest.cpp
    M Source/WebCore/Modules/fetch/FetchResponse.cpp

  Log Message:
  -----------
  Correct URL encoding of fetch module
https://bugs.webkit.org/show_bug.cgi?id=261372
rdar://115219660

Reviewed by Youenn Fablet.

Enforce UTF-8 for two more URL parser calls as the Fetch standard
requires. This aligns us with Gecko and partially with Chromium.
Chromium fails the Response.redirect() case, but this is highly
unlikely to be a web compatibility problem.

Remove the FIXMEs which I presume were added before WebKit got a
standards-compliant URL parser. I at least cannot think of anything
remaining there.

Finally, partially synchronize web-platform-tests/fetch/api/basic up to
and including https://github.com/web-platform-tests/wpt/pull/41894.
Partially as some upstream changes required changes in other
directories.

* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.js:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.js:
(promise_test.async t):
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-null-body.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/response-url-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.js:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-others-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/text-utf8-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=utf8-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=windows-1252-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/url-parsing.sub_encoding=x-cp1251-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/w3c-import.log:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/integrity.sub.any-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.sub.any.worker-expected.txt:
* Source/WebCore/Modules/fetch/FetchRequest.cpp:
(WebCore::computeReferrer):
(WebCore::FetchRequest::initializeWith):
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::redirect):

Canonical link: https://commits.webkit.org/267841@main




More information about the webkit-changes mailing list