[webkit-changes] [WebKit/WebKit] cce771: SerialFunctionDispatcher should implement isCurrent()

Jean-Yves Avenard noreply at github.com
Fri Sep 8 13:03:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cce771ba53901785917c014f762b1fe0a4d52df6
      https://github.com/WebKit/WebKit/commit/cce771ba53901785917c014f762b1fe0a4d52df6
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M Source/WTF/wtf/FunctionDispatcher.h
    M Source/WTF/wtf/MainThread.cpp
    M Source/WTF/wtf/RunLoop.cpp
    M Source/WTF/wtf/RunLoop.h
    M Source/WTF/wtf/WorkQueue.cpp
    M Source/WTF/wtf/WorkQueue.h
    M Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp
    M Source/WTF/wtf/generic/WorkQueueGeneric.cpp
    M Source/WebCore/page/scrolling/ScrollingThread.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
    M Source/WebCore/platform/glib/FileMonitorGLib.cpp
    M Source/WebCore/platform/graphics/ImageSource.cpp
    M Source/WebCore/workers/WorkerOrWorkletThread.cpp
    M Source/WebCore/workers/WorkerOrWorkletThread.h
    M Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp
    M Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.h
    M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
    M Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp

  Log Message:
  -----------
  SerialFunctionDispatcher should implement isCurrent()
https://bugs.webkit.org/show_bug.cgi?id=261008
rdar://114801460

Reviewed by Kimmo Kinnunen.

- Expose isCurrent() to all existing SerialFunctionDispatcher and make
  assertIsCurrent() use isCurrent().
- Make use of assertIsCurrent() in places that were performing similar tests
  and streamline its use for consistency.

* Source/WTF/wtf/FunctionDispatcher.cpp:
(WTF::SerialFunctionDispatcher::assertIsCurrent const):
* Source/WTF/wtf/FunctionDispatcher.h:
* Source/WTF/wtf/RunLoop.cpp:
(WTF::RunLoop::assertIsCurrent const): Deleted.
* Source/WTF/wtf/RunLoop.h:
* Source/WTF/wtf/WorkQueue.cpp:
(WTF::WorkQueue::isCurrent const):
(WTF::WorkQueue::assertIsCurrent const): Deleted.
(WTF::WorkQueue::threadLikeAssertion const): Deleted.
* Source/WTF/wtf/WorkQueue.h:
* Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueueBase::WorkQueueBase):
(WTF::WorkQueueBase::platformInitialize):
(WTF::WorkQueue::WorkQueue):
* Source/WTF/wtf/generic/WorkQueueGeneric.cpp:
(WTF::WorkQueueBase::WorkQueueBase):
(WTF::WorkQueueBase::platformInitialize):
* Source/WebCore/page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::isCurrentThread):
* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
* Source/WebCore/platform/glib/FileMonitorGLib.cpp:
(WebCore::FileMonitor::FileMonitor):
(WebCore::FileMonitor::~FileMonitor):
* Source/WebCore/platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::sourceSize):
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::isCurrent const):
(WebCore::WorkerOrWorkletThread::assertIsCurrent const): Deleted.
* Source/WebCore/workers/WorkerOrWorkletThread.h:
* Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp:
(IPC::StreamConnectionWorkQueue::isCurrent const):
(IPC::StreamConnectionWorkQueue::assertIsCurrent const): Deleted.
* Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.h:
(IPC::WTF_ASSERTS_ACQUIRED_CAPABILITY): Deleted.
* Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::~CompositingRunLoop):
(WebKit::CompositingRunLoop::isCurrent const):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267808@main




More information about the webkit-changes mailing list