[webkit-changes] [WebKit/WebKit] d0ef72: Remove debug-only asserts added in 266304 at main
Eric Carlson
noreply at github.com
Fri Sep 8 12:31:54 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0ef72caf9de05f7e1a710aa63d947e140b5492c
https://github.com/WebKit/WebKit/commit/d0ef72caf9de05f7e1a710aa63d947e140b5492c
Author: Eric Carlson <eric.carlson at apple.com>
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm
Log Message:
-----------
Remove debug-only asserts added in 266304 at main
https://bugs.webkit.org/show_bug.cgi?id=261343
rdar://113674840
Reviewed by Jer Noble.
The asserts added in https://commits.webkit.org/266304@main test a condition that sometimes
happens because we fire the end fullscreen event *before* exiting fullscreen to allow the
page to restore the video element size/position so the exit fullscreen animation looks
correct. The condition isn't a problem because already we call the completion handler and
return early when it is true.
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenToModeWithoutAnimation):
Canonical link: https://commits.webkit.org/267807@main
More information about the webkit-changes
mailing list