[webkit-changes] [WebKit/WebKit] e1280c: [ANGLE] Don't lose Metal-backed contexts for non-f...
Dan Glastonbury
noreply at github.com
Fri Sep 8 04:03:30 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e1280c457e8cab275fc3483e816c59d95fd1a2c7
https://github.com/WebKit/WebKit/commit/e1280c457e8cab275fc3483e816c59d95fd1a2c7
Author: Dan Glastonbury <djg at apple.com>
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm
Log Message:
-----------
[ANGLE] Don't lose Metal-backed contexts for non-fatal errors
https://bugs.webkit.org/show_bug.cgi?id=261313
rdar://115152037
Reviewed by Kimmo Kinnunen.
Since Bug 257584, Any errors from Metal command buffer submission are treated as
causing a lost device.
MTLCommandBufferErrorNotPermitted is a non-fatal error that is reported when a
page with active WebGL moves to the background on iPhoneOS/iPadOS. This error is
ignored to avoid needlessly losing all WebGL contexts since they can't be
recovered once lost and need to be recreated.
* Source/ThirdParty/ANGLE/changes.diff:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm:
(rx::mtl::CommandQueue::onCommandBufferCompleted):
Canonical link: https://commits.webkit.org/267784@main
More information about the webkit-changes
mailing list