[webkit-changes] [WebKit/WebKit] 45ad18: [ANGLE] Fix sRGB Framebuffer blits

Dan Glastonbury noreply at github.com
Fri Sep 8 03:45:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45ad18d66f2afbb7b7e5efa3069e7a9e0bc2c137
      https://github.com/WebKit/WebKit/commit/45ad18d66f2afbb7b7e5efa3069e7a9e0bc2c137
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-test.html
    M LayoutTests/webgl/resources/webgl_test_files/conformance2/rendering/blitframebuffer-test.html
    M Source/ThirdParty/ANGLE/changes.diff
    M Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp

  Log Message:
  -----------
  [ANGLE] Fix sRGB Framebuffer blits
https://bugs.webkit.org/show_bug.cgi?id=261258
rdar://115063488

Reviewed by Kimmo Kinnunen.

ANGLE update in Bug 261026 broke the support for BGRA with sRGB color space
frame buffer blits added in Bug 258104. We fix it by converting both sRGB
formats with alpha into RGBA8.

* LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-test.html:
* LayoutTests/webgl/resources/webgl_test_files/conformance2/rendering/blitframebuffer-test.html:
SRGB8_ALPHA8 is equivalent to RGBA8, so change to RGB8 which isn't equivalent.
* Source/ThirdParty/ANGLE/changes.diff:
* Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:
(gl::EquivalentBlitInternalFormat):

Canonical link: https://commits.webkit.org/267783@main




More information about the webkit-changes mailing list