[webkit-changes] [WebKit/WebKit] d72e06: Fix content-visibility-048.html

Rob Buis noreply at github.com
Thu Sep 7 12:34:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d72e06f60a0cc794bb5299e2c0394aa10e3ed662
      https://github.com/WebKit/WebKit/commit/d72e06f60a0cc794bb5299e2c0394aa10e3ed662
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-048-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html
    A LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html
    A LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  Fix content-visibility-048.html
https://bugs.webkit.org/show_bug.cgi?id=261032

Reviewed by Ryosuke Niwa.

Fix content-visibility-048.html by implementing [1], i.e. set the CSS target given the range.

The remaining failure in content-visibility-048.html is because the range resulting from the
fragment text directive is centered in the selection, but the same thing happens without
content-visibility.

[1] https://wicg.github.io/scroll-to-text-fragment/#invoking-text-directives (Monkeypatching HTML § 7.4.6.3 Scrolling to a fragment)

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-048-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html: Added.
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollToFragment):

Canonical link: https://commits.webkit.org/267744@main




More information about the webkit-changes mailing list