[webkit-changes] [WebKit/WebKit] 1fb4cd: [WebCodecs] AudioDecoder follow-up after 267403 at main

Philippe Normand noreply at github.com
Thu Sep 7 12:14:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fb4cdd856dd56a4c6b7973ed2a798f8d2e3a793
      https://github.com/WebKit/WebKit/commit/1fb4cdd856dd56a4c6b7973ed2a798f8d2e3a793
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.h
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl
    M Source/WebCore/platform/AudioDecoder.cpp

  Log Message:
  -----------
  [WebCodecs] AudioDecoder follow-up after 267403 at main
https://bugs.webkit.org/show_bug.cgi?id=260958

Reviewed by Youenn Fablet.

The AudioDecoder config validation now follows the spec more closely. Some tests still fail, not
catching the exception raised when configuring the decoder with an invalid config, but the same
failures happen in the VideoDecoder, so both should be addressed in a separate patch.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp:
(WebCore::isValidDecoderConfig):
(WebCore::createAudioDecoderConfig):
(WebCore::WebCodecsAudioDecoder::configure):
(WebCore::WebCodecsAudioDecoder::isConfigSupported):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.h:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl:
* Source/WebCore/platform/AudioDecoder.cpp:
(WebCore::AudioDecoder::isCodecSupported):

Canonical link: https://commits.webkit.org/267743@main




More information about the webkit-changes mailing list