[webkit-changes] [WebKit/WebKit] cbed4b: Add argument parsing and error handling for the ta...

Timothy Hatcher noreply at github.com
Wed Sep 6 18:17:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbed4bc921fd108d498644804120bb96798f2a69
      https://github.com/WebKit/WebKit/commit/cbed4bc921fd108d498644804120bb96798f2a69
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in
    A Source/WebKit/Shared/Extensions/WebExtensionTabQueryParameters.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindows.h
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  -----------
  Add argument parsing and error handling for the tabs Web Extension APIs.
https://webkit.org/b/260994
rdar://problem/114787376

Reviewed by Brian Weinstein.

Add all arguments and type processing for the base tabs APIs.

* Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in: Added WebExtensionTabQueryParameters.
* Source/WebKit/Shared/Extensions/WebExtensionTabQueryParameters.h: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm:
(WebKit::toWebAPI): Added.
(WebKit::WebExtensionAPITabs::parseTabCreateOptions): Added.
(WebKit::WebExtensionAPITabs::parseTabUpdateOptions): Added.
(WebKit::WebExtensionAPITabs::parseTabQueryOptions): Added.
(WebKit::isValid): Added.
(WebKit::WebExtensionAPITabs::isPropertyAllowed):
(WebKit::WebExtensionAPITabs::createTab):
(WebKit::WebExtensionAPITabs::query):
(WebKit::WebExtensionAPITabs::get):
(WebKit::WebExtensionAPITabs::getCurrent):
(WebKit::WebExtensionAPITabs::getSelected):
(WebKit::WebExtensionAPITabs::duplicate):
(WebKit::WebExtensionAPITabs::update):
(WebKit::WebExtensionAPITabs::remove):
(WebKit::WebExtensionAPITabs::reload):
(WebKit::WebExtensionAPITabs::goBack):
(WebKit::WebExtensionAPITabs::goForward):
(WebKit::WebExtensionAPITabs::getZoom):
(WebKit::WebExtensionAPITabs::setZoom):
(WebKit::WebExtensionAPITabs::detectLanguage):
(WebKit::WebExtensionAPITabs::toggleReaderMode):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm:
(WebKit::WebExtensionAPIWindows::parseWindowTypeFilter): Added.
(WebKit::isValid): Removed inline to use in WebExtensionAPITabs.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindows.h:
* Tools/TestWebKitAPI/SourcesCocoa.txt: Added WKWebExtensionAPITabs.mm.
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: Added.
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267709@main




More information about the webkit-changes mailing list