[webkit-changes] [WebKit/WebKit] 8c3dd6: Seeing 5 windows opened, even though only tapped o...

[Dean Jackson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c3dd61568c98905d1eb9bdeb901fbe099e6b5c4
      https://github.com/WebKit/WebKit/commit/8c3dd61568c98905d1eb9bdeb901fbe099e6b5c4
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
    M Source/WebKit/UIProcess/SystemPreviewController.h

  Log Message:
  -----------
  Seeing 5 windows opened, even though only tapped on 3 model links from Safari
https://bugs.webkit.org/show_bug.cgi?id=261232
rdar://114172309

Reviewed by Mike Wyrzykowski.

On iOS the AR Quick Look feature is modal, which means only one preview
is open at a time. On visionOS the preview opens in a separate app, allowing
for the case where the user can tap many times and multiple windows open.
Furthermore, the communication with the system is a bit limited, which
can create a situation where more windows open than the user requested.

Limit this so that only one Quick Look can be downloading at a time. This
will still allow the user to open multiple models, but not get into this
confusing situation.

It isn't a great fix. A future change would be to keep a list of
active previews, with an upper limit, so that the user isn't blocked
from opening another file while a large file is being downloaded.

* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
* Source/WebKit/UIProcess/SystemPreviewController.h:

Canonical link: https://commits.webkit.org/267708@main