[webkit-changes] [WebKit/WebKit] 5736f9: Check for NaN when creating a DelayNode for WebAudio

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5736f9dd89eab88f61ab2755cc11ea8bdcd08af3
      https://github.com/WebKit/WebKit/commit/5736f9dd89eab88f61ab2755cc11ea8bdcd08af3
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt
    M LayoutTests/webaudio/delaynode-maxdelaylimit.html
    M Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp
    M Source/WebCore/Modules/webaudio/DelayNode.cpp

  Log Message:
  -----------
  Check for NaN when creating a DelayNode for WebAudio

https://bugs.webkit.org/show_bug.cgi?id=261067

Reviewed by Chris Dumez.

Merge: https://chromium.googlesource.com/chromium/src.git/+/c8c4a710be6292a220177fef0c3f1c7c7853d062

In createDelay(), throw an exception if the specified delay is NaN.
Check a few other places for NaN where we are creating a buffer based
on that value.

Update a layout test to check that createDelay(NaN) throws an
exception.

* Source/WebCore/Modules/webaudio/DelayNode.cpp:
(DelayNode::create):
* Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:
(DelayDSPKernel::DelayDSPKernel):
* LayoutTests/webaudio/delaynode-maxdelaylimit.html: Rebaselined
* LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/267650@main