[webkit-changes] [WebKit/WebKit] 662e37: prepare-commit-msg hook doesn't generate a changed...

Fujii Hironori noreply at github.com
Tue Sep 5 13:38:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 662e3790e0b6902fe02cd8594c47052a8bb935c9
      https://github.com/WebKit/WebKit/commit/662e3790e0b6902fe02cd8594c47052a8bb935c9
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M Tools/Scripts/hooks/prepare-commit-msg
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py

  Log Message:
  -----------
  prepare-commit-msg hook doesn't generate a changed file list with Windows Git
https://bugs.webkit.org/show_bug.cgi?id=261097

Reviewed by Jonathan Bedard.

prepare-ChangeLog reproted "Can't locate VCSUtils.pm in @INC" error if
it was executed from prepare-commit-msg hook of Windows Git. It failed
to set a library path to 'Tools/Scripts' directory.

Windows Git includes msys perl. prepare-commit-msg hook unexpectedly
executed it. It should execute Windows Perl.

Use shutil.which to get perl's absolute path. But, it's available for
Python 3.3 or newer. Windows port developers have been switched to
Python 3. Use the original relative command name 'perl' for older
Python.

* Tools/Scripts/hooks/prepare-commit-msg:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
* (InstallHooks.main): Added a new template variable 'perl' to set
perl's absolute path.

Canonical link: https://commits.webkit.org/267649@main




More information about the webkit-changes mailing list