[webkit-changes] [WebKit/WebKit] e9e936: Let the compiler generate more comparison operator...

Chris Dumez noreply at github.com
Tue Sep 5 12:41:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9e93692891c06a791d49233208a7da7c504bd4f
      https://github.com/WebKit/WebKit/commit/e9e93692891c06a791d49233208a7da7c504bd4f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
    M Source/JavaScriptCore/b3/B3Effects.cpp
    M Source/JavaScriptCore/b3/B3Effects.h
    M Source/JavaScriptCore/b3/B3GenericFrequentedBlock.h
    M Source/JavaScriptCore/b3/B3Kind.h
    M Source/JavaScriptCore/b3/B3Origin.h
    M Source/JavaScriptCore/b3/B3Type.h
    M Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp
    M Source/JavaScriptCore/b3/air/AirAllocateStackByGraphColoring.cpp
    M Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp
    M Source/JavaScriptCore/b3/air/AirKind.h
    M Source/JavaScriptCore/b3/air/AirTmp.h
    M Source/JavaScriptCore/b3/air/AirTmpSet.h
    M Source/JavaScriptCore/bytecode/AccessCase.h
    M Source/JavaScriptCore/bytecode/ArithProfile.h
    M Source/JavaScriptCore/bytecode/BytecodeRewriter.h
    M Source/JavaScriptCore/bytecode/CallVariant.h
    M Source/JavaScriptCore/bytecode/CodeBlockHash.h
    M Source/JavaScriptCore/bytecode/DFGExitProfile.h
    M Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h
    M Source/JavaScriptCore/bytecode/ObjectPropertyCondition.h
    M Source/JavaScriptCore/bytecode/StructureStubInfo.h
    M Source/JavaScriptCore/bytecode/VirtualRegister.h
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h
    M Source/JavaScriptCore/debugger/DebuggerScope.h
    M Source/JavaScriptCore/dfg/DFGAbstractHeap.h
    M Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h
    M Source/JavaScriptCore/dfg/DFGAvailability.h
    M Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp
    M Source/JavaScriptCore/dfg/DFGAvailabilityMap.h
    M Source/JavaScriptCore/dfg/DFGDesiredGlobalProperty.h
    M Source/JavaScriptCore/dfg/DFGEdge.h
    M Source/JavaScriptCore/dfg/DFGEpoch.h
    M Source/JavaScriptCore/dfg/DFGFlushedAt.h
    M Source/JavaScriptCore/dfg/DFGHeapLocation.h
    M Source/JavaScriptCore/dfg/DFGIntegerCheckCombiningPhase.cpp
    M Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h
    M Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp
    M Source/JavaScriptCore/dfg/DFGPromotedHeapLocation.h
    M Source/JavaScriptCore/dfg/DFGPropertyTypeKey.h
    M Source/JavaScriptCore/dfg/DFGRegisteredStructure.h
    M Source/JavaScriptCore/heap/Allocator.h
    M Source/JavaScriptCore/heap/HeapFinalizerCallback.h
    M Source/JavaScriptCore/heap/MarkingConstraintSolver.h
    M Source/JavaScriptCore/heap/VisitRaceKey.h
    M Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h
    M Source/JavaScriptCore/interpreter/CallFrame.h
    M Source/JavaScriptCore/interpreter/ShadowChicken.h
    M Source/JavaScriptCore/jit/GPRInfo.h
    M Source/JavaScriptCore/jit/JITAllocator.h
    M Source/JavaScriptCore/jit/JITCompilationKey.h
    M Source/JavaScriptCore/jit/Reg.h
    M Source/JavaScriptCore/jit/RegisterAtOffset.h
    M Source/JavaScriptCore/jit/RegisterSet.h
    M Source/JavaScriptCore/jit/SIMDInfo.h
    M Source/JavaScriptCore/parser/ParserTokens.h
    M Source/JavaScriptCore/parser/SourceCode.h
    M Source/JavaScriptCore/parser/SourceCodeKey.h
    M Source/JavaScriptCore/parser/UnlinkedSourceCode.h
    M Source/JavaScriptCore/parser/VariableEnvironment.h
    M Source/JavaScriptCore/profiler/ProfilerOrigin.h
    M Source/JavaScriptCore/profiler/ProfilerUID.h
    M Source/JavaScriptCore/runtime/CacheableIdentifierInlines.h
    M Source/JavaScriptCore/runtime/ControlFlowProfiler.h
    M Source/JavaScriptCore/runtime/DOMAnnotation.h
    M Source/JavaScriptCore/runtime/FunctionHasExecutedCache.h
    M Source/JavaScriptCore/runtime/GenericOffset.h
    M Source/JavaScriptCore/runtime/ISO8601.h
    M Source/JavaScriptCore/runtime/JSScope.h
    M Source/JavaScriptCore/runtime/PageCount.h
    M Source/JavaScriptCore/runtime/PrototypeKey.h
    M Source/JavaScriptCore/runtime/StructureID.h
    M Source/JavaScriptCore/runtime/StructureTransitionTable.h
    M Source/JavaScriptCore/runtime/TypeLocationCache.h
    M Source/JavaScriptCore/runtime/TypeProfiler.h
    M Source/JavaScriptCore/runtime/VarOffset.h
    M Source/JavaScriptCore/wasm/WasmTypeDefinition.h

  Log Message:
  -----------
  Let the compiler generate more comparison operators in JSC
https://bugs.webkit.org/show_bug.cgi?id=261127

Reviewed by Keith Miller.

Let the compiler generate more comparison operators in JSC now that we
support C++20.

* Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::operator== const): Deleted.
* Source/JavaScriptCore/assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::operator== const): Deleted.
* Source/JavaScriptCore/b3/B3Effects.cpp:
(JSC::B3::Effects::operator== const): Deleted.
* Source/JavaScriptCore/b3/B3Effects.h:
* Source/JavaScriptCore/b3/B3GenericFrequentedBlock.h:
(JSC::B3::GenericFrequentedBlock::operator== const): Deleted.
* Source/JavaScriptCore/b3/B3Kind.h:
(JSC::B3::Kind::operator== const): Deleted.
* Source/JavaScriptCore/b3/B3Origin.h:
(JSC::B3::Origin::operator== const): Deleted.
* Source/JavaScriptCore/b3/B3Type.h:
(JSC::B3::Type::operator== const): Deleted.
* Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:
* Source/JavaScriptCore/b3/air/AirAllocateStackByGraphColoring.cpp:
* Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp:
* Source/JavaScriptCore/b3/air/AirKind.h:
(JSC::B3::Air::Kind::operator== const): Deleted.
* Source/JavaScriptCore/b3/air/AirTmp.h:
(JSC::B3::Air::Tmp::operator== const): Deleted.
* Source/JavaScriptCore/b3/air/AirTmpSet.h:
(JSC::B3::Air::TmpSet::iterator::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/AccessCase.h:
(JSC::SharedJITStubSet::Hash::Key::operator==): Deleted.
* Source/JavaScriptCore/bytecode/ArithProfile.h:
(JSC::ObservedType::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/BytecodeRewriter.h:
(JSC::BytecodeRewriter::InsertionPoint::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/CallVariant.h:
(JSC::CallVariant::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/CodeBlockHash.h:
(JSC::CodeBlockHash::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/CodeOrigin.h:
(JSC::CodeOrigin::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/DFGExitProfile.h:
(JSC::DFG::FrequentExitSite::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:
(JSC::LazyOperandValueProfileKey::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/ObjectPropertyCondition.h:
(JSC::ObjectPropertyCondition::operator== const): Deleted.
* Source/JavaScriptCore/bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::BufferedStructure::operator==): Deleted.
* Source/JavaScriptCore/bytecode/VirtualRegister.h:
(JSC::VirtualRegister::operator== const): Deleted.
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:
(JSC::Variable::operator== const): Deleted.
* Source/JavaScriptCore/debugger/DebuggerScope.h:
* Source/JavaScriptCore/dfg/DFGAbstractHeap.h:
(JSC::DFG::AbstractHeap::Payload::operator== const): Deleted.
(JSC::DFG::AbstractHeap::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h:
(JSC::DFG::AbstractValueClobberEpoch::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGAvailability.h:
(JSC::DFG::Availability::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp:
(JSC::DFG::AvailabilityMap::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGAvailabilityMap.h:
* Source/JavaScriptCore/dfg/DFGDesiredGlobalProperty.h:
(JSC::DFG::DesiredGlobalProperty::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGEdge.h:
(JSC::DFG::Edge::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGEpoch.h:
(JSC::DFG::Epoch::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGFlushedAt.h:
(JSC::DFG::FlushedAt::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGHeapLocation.h:
(JSC::DFG::HeapLocation::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGIntegerCheckCombiningPhase.cpp:
(JSC::DFG::IntegerCheckCombiningPhase::RangeKey::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h:
(JSC::DFG::NodeFlowProjection::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:
* Source/JavaScriptCore/dfg/DFGPromotedHeapLocation.h:
(JSC::DFG::PromotedLocationDescriptor::operator== const): Deleted.
(JSC::DFG::PromotedHeapLocation::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGPropertyTypeKey.h:
(JSC::DFG::PropertyTypeKey::operator== const): Deleted.
* Source/JavaScriptCore/dfg/DFGRegisteredStructure.h:
(JSC::DFG::RegisteredStructure::operator== const): Deleted.
* Source/JavaScriptCore/heap/Allocator.h:
(JSC::Allocator::operator== const): Deleted.
* Source/JavaScriptCore/heap/HeapFinalizerCallback.h:
(JSC::HeapFinalizerCallback::operator== const): Deleted.
* Source/JavaScriptCore/heap/MarkingConstraintSolver.h:
(JSC::MarkingConstraintSolver::TaskWithConstraint::operator== const): Deleted.
* Source/JavaScriptCore/heap/VisitRaceKey.h:
(JSC::VisitRaceKey::operator== const): Deleted.
* Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h:
* Source/JavaScriptCore/interpreter/CallFrame.h:
(JSC::CallSiteIndex::operator== const): Deleted.
* Source/JavaScriptCore/interpreter/ShadowChicken.h:
(JSC::ShadowChicken::Frame::operator== const): Deleted.
* Source/JavaScriptCore/jit/GPRInfo.h:
(JSC::JSValueRegs::operator== const): Deleted.
* Source/JavaScriptCore/jit/JITAllocator.h:
(JSC::JITAllocator::operator== const): Deleted.
* Source/JavaScriptCore/jit/JITCompilationKey.h:
(JSC::JITCompilationKey::operator== const): Deleted.
* Source/JavaScriptCore/jit/Reg.h:
(JSC::Reg::operator== const): Deleted.
(JSC::Reg::AllRegsIterable::iterator::operator== const): Deleted.
* Source/JavaScriptCore/jit/RegisterAtOffset.h:
(JSC::RegisterAtOffset::operator== const): Deleted.
* Source/JavaScriptCore/jit/RegisterSet.h:
* Source/JavaScriptCore/jit/SIMDInfo.h:
(JSC::SIMDInfo::operator==): Deleted.
* Source/JavaScriptCore/parser/ParserTokens.h:
(JSC::JSTextPosition::operator== const): Deleted.
* Source/JavaScriptCore/parser/SourceCode.h:
(JSC::SourceCode::operator== const): Deleted.
* Source/JavaScriptCore/parser/SourceCodeKey.h:
(JSC::SourceCodeFlags::operator== const): Deleted.
* Source/JavaScriptCore/parser/UnlinkedSourceCode.h:
* Source/JavaScriptCore/parser/VariableEnvironment.h:
(JSC::VariableEnvironmentEntry::operator== const): Deleted.
(JSC::PrivateNameEntry::operator== const): Deleted.
* Source/JavaScriptCore/profiler/ProfilerOrigin.h:
(JSC::Profiler::Origin::operator== const): Deleted.
* Source/JavaScriptCore/profiler/ProfilerUID.h:
(JSC::Profiler::UID::operator== const): Deleted.
* Source/JavaScriptCore/runtime/CacheableIdentifier.h:
* Source/JavaScriptCore/runtime/CacheableIdentifierInlines.h:
* Source/JavaScriptCore/runtime/ControlFlowProfiler.h:
(JSC::BasicBlockKey::operator== const): Deleted.
* Source/JavaScriptCore/runtime/DOMAnnotation.h:
(JSC::operator==): Deleted.
* Source/JavaScriptCore/runtime/FunctionHasExecutedCache.h:
(JSC::FunctionHasExecutedCache::FunctionRange::operator== const): Deleted.
* Source/JavaScriptCore/runtime/GenericOffset.h:
(JSC::GenericOffset::operator== const): Deleted.
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/JSScope.h:
(JSC::ScopeChainIterator::operator== const): Deleted.
* Source/JavaScriptCore/runtime/PageCount.h:
(JSC::PageCount::operator== const): Deleted.
* Source/JavaScriptCore/runtime/PrototypeKey.h:
(JSC::PrototypeKey::operator== const): Deleted.
* Source/JavaScriptCore/runtime/StructureID.h:
(JSC::StructureID::operator== const): Deleted.
* Source/JavaScriptCore/runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::Key::operator==): Deleted.
* Source/JavaScriptCore/runtime/TypeLocationCache.h:
(JSC::TypeLocationCache::LocationKey::operator== const): Deleted.
* Source/JavaScriptCore/runtime/TypeProfiler.h:
(JSC::QueryKey::operator== const): Deleted.
* Source/JavaScriptCore/runtime/VarOffset.h:
(JSC::VarOffset::operator== const): Deleted.
* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
(JSC::Wasm::FieldType::operator== const): Deleted.

Canonical link: https://commits.webkit.org/267645@main




More information about the webkit-changes mailing list