[webkit-changes] [WebKit/WebKit] af201f: (REGRESSION 267456 at main) Loading

Alan Baradlay noreply at github.com
Tue Sep 5 12:38:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af201f59b4cb52ab2270155c79f93abf0634a7d2
      https://github.com/WebKit/WebKit/commit/af201f59b4cb52ab2270155c79f93abf0634a7d2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    A LayoutTests/fast/inline/out-of-flow-with-clear-and-float-crash-expected.txt
    A LayoutTests/fast/inline/out-of-flow-with-clear-and-float-crash.html
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp

  Log Message:
  -----------
  (REGRESSION 267456 at main) Loading
https://www.dsogaming.com
 crashes at Box::cachedGeometryForLayoutState
https://bugs.webkit.org/show_bug.cgi?id=261159
<rdar://problem/114984295>

Reviewed by Antti Koivisto.

Out-of-flow boxes do not affect logical top for next line so let's not try to figure out their "cleared" position.

* LayoutTests/fast/inline/out-of-flow-with-clear-and-float-crash-expected.txt: Added.
* LayoutTests/fast/inline/out-of-flow-with-clear-and-float-crash.html: Added.
* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::logicalTopForNextLine const):

Canonical link: https://commits.webkit.org/267644@main




More information about the webkit-changes mailing list