[webkit-changes] [WebKit/WebKit] aaec31: Change --logJIT to dump its header line on a singl...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aaec31beee6cfb4e90729eb3814609a04b776fe2
      https://github.com/WebKit/WebKit/commit/aaec31beee6cfb4e90729eb3814609a04b776fe2
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/LinkBuffer.cpp
    M Source/JavaScriptCore/jit/JITPlan.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  Change --logJIT to dump its header line on a single line.
https://bugs.webkit.org/show_bug.cgi?id=261096
rdar://114916585

Reviewed by Alexey Shvayka.

It currently dumps one "Generated JIT code for ..." line and a second line indicating the bounds
of the JIT code.  This patch makes the 2 into 1 line, and adds JITCode size in bytes to the
dump.  This makes the dump easier to filter out / grep for info about certain JIT code
generation.

Other miscellaneous changes:
1. Removed unused --dumpCompilerConstructionSite option.
2. Changed JITPlan::compileInThread to cache the result of computeCompileTimes(), and to return
   early if it is false.  The rest of the function after the call to compileInThreadImpl() are
   all to do dumps.  Those dumps are gated on conditions which will cause computeCompileTimes()
   to return true if the dump is needed.  Hence, there's no need to do extra work if
   computeCompileTimes() is false.

* Source/JavaScriptCore/assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl):
* Source/JavaScriptCore/jit/JITPlan.cpp:
(JSC::JITPlan::compileInThread):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/267639@main