[webkit-changes] [WebKit/WebKit] 8bf165: WebCodecs/WebRTC VP9 color space is not correctly ...

youennf noreply at github.com
Tue Sep 5 10:56:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8bf16504d7fa82206bfd237c094b116199e702ac
      https://github.com/WebKit/WebKit/commit/8bf16504d7fa82206bfd237c094b116199e702ac
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.js
    M LayoutTests/webrtc/vp9.html
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm
    M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.cpp

  Log Message:
  -----------
  WebCodecs/WebRTC VP9 color space is not correctly set for libvpx encoders
https://bugs.webkit.org/show_bug.cgi?id=261133
rdar://114963848

Reviewed by Eric Carlson.

libvpx encoder is using Bt709 for transfer and matrix, we update the code accordingly.
We override the values for VTB VP9 like we do for VTB H264.
We should probably synchronize these values with vpcC provided values when we have these values, which might happen for WebCodecs.

We update LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.js so that no video frame is GCed unclosed if a test fails.
We update LayoutTests/webrtc/vp9.html to check for color space information as well as allow running the tests in browsers.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.js:
(async runFullCycleTest):
* LayoutTests/webrtc/vp9.html:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:
(overrideVP9ColorSpaceAttachments):
(vp9DecompressionOutputCallback):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp:
(WebCore::LibWebRTCVPXVideoEncoder::create):
* Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.cpp:
(WebCore::defaultVPXColorSpace):

Canonical link: https://commits.webkit.org/267638@main




More information about the webkit-changes mailing list