[webkit-changes] [WebKit/WebKit] 052c4c: [git-webkit] Allow for re-running pre-pr checks

Jonathan Bedard noreply at github.com
Tue Oct 31 07:21:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 052c4c37d40f04042013f66db2bd09c63efdce28
      https://github.com/WebKit/WebKit/commit/052c4c37d40f04042013f66db2bd09c63efdce28
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  -----------
  [git-webkit] Allow for re-running pre-pr checks
https://bugs.webkit.org/show_bug.cgi?id=242536
rdar://97093963

Reviewed by Dewei Zhu.

In webkit-patch, contributors could modify their patch after the style-checker
ran but before the change was uploaded. git-webkit should support a similar
functionality when running pre-pr checks.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pre_pr_checks): If a pre-pr check fails, offer to re-run the
check and if possible, add any modified files to the most recent commit.
(PullRequest.create_pull_request): Pass --no-add onto pre_pr_checks.

Canonical link: https://commits.webkit.org/270007@main




More information about the webkit-changes mailing list