[webkit-changes] [WebKit/WebKit] a20c41: [import-w3c-tests] Drop TestRepositories support

Sam Sneddon noreply at github.com
Tue Oct 31 06:36:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a20c4164307a04b786e621693503957c8cdc0821
      https://github.com/WebKit/WebKit/commit/a20c4164307a04b786e621693503957c8cdc0821
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    R LayoutTests/imported/w3c/resources/TestRepositories
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Drop TestRepositories support
https://bugs.webkit.org/show_bug.cgi?id=258815

Reviewed by Jonathan Bedard.

At this point, we're just carrying along a lot of configurability for
what is actually a single repository we support importing tests from.

Instead, hard-code the relevant data, as this makes it obvious we can
start to drop support for configuration options which are now dead
code. This also makes some of the duplicity of configurability obvious,
with "paths_to_skip" and "paths_to_import" obviously largely redundant
with import-expectations.json.

This also drops support for the "import_options" called
"generate_git_submodules_description" and "generate_gitignore", and
dropping support immediately is the easiest way to get the tests to pass
with the repositories hard-coded.

* LayoutTests/imported/w3c/resources/TestRepositories: Removed.
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.load_test_repositories):
(TestDownloader.update_import_expectations):
(TestDownloader._git_submodules_description): Deleted.
(TestDownloader.generate_git_submodules_description): Deleted.
(TestDownloader.generate_gitignore): Deleted.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.generate_git_submodules_description_for_all_repositories):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_harnesslinks_conversion):
(TestImporterTest.test_skip_test_import_download):

Canonical link: https://commits.webkit.org/270006@main




More information about the webkit-changes mailing list