[webkit-changes] [WebKit/WebKit] c571e2: [WebGPU] Using the stencil reference value as the ...

mwyrzykowski noreply at github.com
Mon Oct 30 10:43:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c571e2a7ad862776ebd54bbd46a351e022526a07
      https://github.com/WebKit/WebKit/commit/c571e2a7ad862776ebd54bbd46a351e022526a07
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pass/clear_value-expected.txt
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Using the stencil reference value as the stencil clear value fails when the reference value is greater than 255
https://bugs.webkit.org/show_bug.cgi?id=263812
<radar://117610399>

Reviewed by Tadeu Zagallo.

The stencil value is masked to the max value in the stencil buffer.

All of our stencil formats are 8 bits and that is not likely to change
as stencil formats have not changed in more than ten years, so mask with 255.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pass/clear_value-expected.txt:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::setStencilReference):

Canonical link: https://commits.webkit.org/269957@main




More information about the webkit-changes mailing list