[webkit-changes] [WebKit/WebKit] d8097a: [WebGPU] Crash in CommandEncoder::beginRenderPass ...

mwyrzykowski noreply at github.com
Mon Oct 30 10:39:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8097a7c08b2d335f5502bd0b0b2b27146b1833c
      https://github.com/WebKit/WebKit/commit/d8097a7c08b2d335f5502bd0b0b2b27146b1833c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pipeline/pipeline_output_targets-expected.txt
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Crash in CommandEncoder::beginRenderPass when writing to targets not starting at zero or not linearly increasing
https://bugs.webkit.org/show_bug.cgi?id=263815
<radar://117612187>

Reviewed by Tadeu Zagallo.

We should not assume targets are written to like 0,1,2, and so on.

It could be 1, 3, or 0, 2, or 0, 3 for instance.

With this change, we have another passing CTS test.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pipeline/pipeline_output_targets-expected.txt:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/269956@main




More information about the webkit-changes mailing list