[webkit-changes] [WebKit/WebKit] 7b16f5: WebGLRenderingContextBase::m_needsUpdate is a redu...

Kimmo Kinnunen noreply at github.com
Thu Oct 26 23:20:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b16f53a6ca333f87a4d6a38f399b18118b3413a
      https://github.com/WebKit/WebKit/commit/7b16f53a6ca333f87a4d6a38f399b18118b3413a
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h

  Log Message:
  -----------
  WebGLRenderingContextBase::m_needsUpdate is a redundant flag
https://bugs.webkit.org/show_bug.cgi?id=263648
rdar://117469562

Reviewed by Dan Glastonbury.

Remove m_needsUpdate. It controlled the
`renderBox->contentChanged(CanvasChanged)` call when the context was
created during reshape, only the first time after a context creation.

Initial creation for HTMLCanvasElement will call contentChanged
explicitly.

Upon restoring lost context, this is called after successful restore.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeContextState):
(WebCore::WebGLRenderingContextBase::reshape):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: https://commits.webkit.org/269841@main




More information about the webkit-changes mailing list