[webkit-changes] [WebKit/WebKit] 0c97b9: Stabilise and improve keynote/numbers/pages attach...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c97b9e472f42b3ed1de7293edaf792b7b3bba07
      https://github.com/WebKit/WebKit/commit/0c97b9e472f42b3ed1de7293edaf792b7b3bba07
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M LayoutTests/fast/attachment/mac/attachment-keynote-expected-mismatch.html
    A LayoutTests/fast/attachment/mac/attachment-keynote-icon-expected.html
    A LayoutTests/fast/attachment/mac/attachment-keynote-icon.html
    M LayoutTests/fast/attachment/mac/attachment-keynote.html
    M LayoutTests/fast/attachment/mac/attachment-numbers-expected-mismatch.html
    A LayoutTests/fast/attachment/mac/attachment-numbers-icon-expected.html
    A LayoutTests/fast/attachment/mac/attachment-numbers-icon.html
    M LayoutTests/fast/attachment/mac/attachment-numbers.html
    M LayoutTests/fast/attachment/mac/attachment-pages-expected-mismatch.html
    A LayoutTests/fast/attachment/mac/attachment-pages-icon-expected.html
    A LayoutTests/fast/attachment/mac/attachment-pages-icon.html
    M LayoutTests/fast/attachment/mac/attachment-pages.html
    A LayoutTests/fast/attachment/resources/test-file.key
    A LayoutTests/fast/attachment/resources/test-file.numbers
    A LayoutTests/fast/attachment/resources/test-file.pages
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  Stabilise and improve keynote/numbers/pages attachment tests
https://bugs.webkit.org/show_bug.cgi?id=262987
rdar://116777261

Reviewed by Aditya Keerthi.

Attachment-{keynote,numbers,pages}.html were flaky, with the actual and/or
expected rendering sometimes missing the icon, because that icon is only
fetched during the first rendering.

* LayoutTests/fast/attachment/mac/attachment-keynote.html:
* LayoutTests/fast/attachment/mac/attachment-numbers.html:
* LayoutTests/fast/attachment/mac/attachment-pages.html:
Use reftest-wait and takeScreenshotWhenAttachmentsSettled to delay the
test screenshot until there is an icon.

* LayoutTests/fast/attachment/mac/attachment-keynote-expected-mismatch.html:
* LayoutTests/fast/attachment/mac/attachment-numbers-expected-mismatch.html:
* LayoutTests/fast/attachment/mac/attachment-pages-expected-mismatch.html:
Instead of comparing a mismatch against nothing at all, compare with
an attachment with just a different icon.

* LayoutTests/fast/attachment/mac/attachment-keynote-icon-expected.html: Added.
* LayoutTests/fast/attachment/mac/attachment-keynote-icon.html: Added.
* LayoutTests/fast/attachment/mac/attachment-numbers-icon-expected.html: Added.
* LayoutTests/fast/attachment/mac/attachment-numbers-icon.html: Added.
* LayoutTests/fast/attachment/mac/attachment-pages-icon-expected.html: Added.
* LayoutTests/fast/attachment/mac/attachment-pages-icon.html: Added.
New tests that check that the keynote/numbers/pages icons can be set
through the title or the file attribute.

* LayoutTests/fast/attachment/resources/test-file.key: Added.
* LayoutTests/fast/attachment/resources/test-file.numbers: Added.
* LayoutTests/fast/attachment/resources/test-file.pages: Added.
Empty files that can be referenced from the above tests.

* LayoutTests/platform/mac-wk2/TestExpectations:
Removed gardening changes.

Canonical link: https://commits.webkit.org/269840@main