[webkit-changes] [WebKit/WebKit] ea4f8e: Adopt more smart pointers in RenderElement

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea4f8e5ea638e3d82f8a87811aa8c9654cabf993
      https://github.com/WebKit/WebKit/commit/ea4f8e5ea638e3d82f8a87811aa8c9654cabf993
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/EventHandler.h
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/cocoa/EventHandlerCocoa.mm
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderObjectInlines.h
    M Source/WebCore/rendering/style/FillLayer.h
    M Source/WebCore/rendering/style/NinePieceImage.h
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/ShapeValue.h

  Log Message:
  -----------
  Adopt more smart pointers in RenderElement
https://bugs.webkit.org/show_bug.cgi?id=263542

Reviewed by Ryosuke Niwa.

Adopt more smart pointers in RenderElement.

I also made some changes to EventHandler so that we can store it in
a CheckedPtr / CheckedRef. I made it forward its checked pointer count
to its associated frame since it is owned by the frame. As extra safety,
I made EventHandler::m_frame be a CheckedRef<Frame> which required me
to update all uses of m_frame in this file. That said, the changes in
EventHandler are NOT meant to be exhaustive.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::protectedView const):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::incrementPtrCount const):
(WebCore::EventHandler::decrementPtrCount const):
* Source/WebCore/page/EventHandler.h:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::checkedEventHandler):
(WebCore::LocalFrame::checkedEventHandler const):
(WebCore::Document::protectedView const): Deleted.
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
(WebCore::RenderElement::updateFillImages):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::repaintBeforeStyleChange):
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::didAttachChild):
(WebCore::RenderElement::attachRendererInternal):
(WebCore::RenderElement::detachRendererInternal):
(WebCore::findNextLayer):
(WebCore::layerNextSiblingRespectingTopLayer):
(WebCore::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::layerParent const):
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):
(WebCore::RenderElement::clearSubtreeLayoutRootIfNeeded const):
(WebCore::RenderElement::willBeDestroyed):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::protectedFrame const):
* Source/WebCore/rendering/RenderObjectInlines.h:
(WebCore::RenderObject::protectedDocument const):
* Source/WebCore/rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::protectedImage const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::protectedBackgroundLayers const):
(WebCore::RenderStyle::protectedMaskLayers const):
(WebCore::RenderStyle::protectedShapeOutside const):
* Source/WebCore/rendering/style/ShapeValue.h:
(WebCore::ShapeValue::protectedImage const):

Canonical link: https://commits.webkit.org/269712@main