[webkit-changes] [WebKit/WebKit] cca919: Make dir=auto and dirname apply to more input types

Tue Oct 24 06:35:52 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cca91933e49817aee5757144398751412476d8dd
      https://github.com/WebKit/WebKit/commit/cca91933e49817aee5757144398751412476d8dd
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element.html
    A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window.html
    A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window.js
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-iframe.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-auto-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-auto.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-inherited-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-inherited.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-iframe.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname.js
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/w3c-import.log
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/w3c-import.log
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt
    A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt
    A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt
    M Source/WebCore/html/BaseButtonInputType.cpp
    M Source/WebCore/html/BaseButtonInputType.h
    M Source/WebCore/html/BaseTextInputType.h
    M Source/WebCore/html/FileInputType.cpp
    M Source/WebCore/html/FileInputType.h
    M Source/WebCore/html/HiddenInputType.cpp
    M Source/WebCore/html/HiddenInputType.h
    M Source/WebCore/html/ImageInputType.cpp
    M Source/WebCore/html/ImageInputType.h
    M Source/WebCore/html/PasswordInputType.cpp
    M Source/WebCore/html/PasswordInputType.h
    M Source/WebCore/html/SubmitInputType.cpp
    M Source/WebCore/html/TextFieldInputType.cpp

  Log Message:
  -----------
  Make dir=auto and dirname apply to more input types
https://bugs.webkit.org/show_bug.cgi?id=259440
rdar://113127508

Reviewed by Ryosuke Niwa.

This applies dir=auto to Hidden, Password, Submit Button, Reset Button,
and Button input types.

It also supports the dirname attribute for Password and Submit Button
input types and removes support for it from Number input types.

Tests are kept synchronized via
https://github.com/web-platform-tests/wpt/pull/42427.

Standard is updated in https://github.com/whatwg/html/pull/9689.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element.html:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window.js: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-auto-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-auto.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-inherited-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-rtl-inherited.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-iframe.html.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname.js: Added.
(onIframeLoadedDone):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/w3c-import.log: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/w3c-import.log:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt: Added.
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies-expected.txt: Added.
* Source/WebCore/html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::dirAutoUsesValue const):
* Source/WebCore/html/BaseButtonInputType.h:
* Source/WebCore/html/BaseTextInputType.h:
* Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::dirAutoUsesValue const):
* Source/WebCore/html/FileInputType.h:
* Source/WebCore/html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData const):
(WebCore::HiddenInputType::dirAutoUsesValue const):
* Source/WebCore/html/HiddenInputType.h:
* Source/WebCore/html/ImageInputType.cpp:
(WebCore::ImageInputType::dirAutoUsesValue const):
* Source/WebCore/html/ImageInputType.h:
* Source/WebCore/html/PasswordInputType.cpp:
(WebCore::PasswordInputType::dirAutoUsesValue const): Deleted.
* Source/WebCore/html/PasswordInputType.h:
* Source/WebCore/html/SubmitInputType.cpp:
(WebCore::SubmitInputType::appendFormData const):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::appendFormData const):

Canonical link: https://commits.webkit.org/269711@main