[webkit-changes] [WebKit/WebKit] 003107: Disabled inputs should not get Interaction Regions

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0031075b36df98b33c4fe43e8188a64f1f94965d
      https://github.com/WebKit/WebKit/commit/0031075b36df98b33c4fe43e8188a64f1f94965d
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-10-21 (Sat, 21 Oct 2023)

  Changed paths:
    A LayoutTests/interaction-region/disabled-controls-expected.txt
    A LayoutTests/interaction-region/disabled-controls.html
    M LayoutTests/interaction-region/interaction-layers-culling-expected.txt
    M LayoutTests/interaction-region/labels-expected.txt
    M LayoutTests/interaction-region/labels.html
    M LayoutTests/interaction-region/layer-tree-expected.txt
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Disabled inputs should not get Interaction Regions
https://bugs.webkit.org/show_bug.cgi?id=263379
<rdar://116931433>

Reviewed by Wenson Hsieh and Aditya Keerthi.

Before generating an Interaction Region for an input, or a label
associated with an input, make sure the label is enabled.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowElement):
Disallow disabled inputs.
(WebCore::interactionRegionForRenderedRegion):
Check if the label's associated element is enabled.

* LayoutTests/interaction-region/labels.html:
* LayoutTests/interaction-region/labels-expected.txt:
Update the labels test to cover this case. No new region in the
expectation since we're not generating extra regions.
* LayoutTests/interaction-region/disabled-controls-expected.txt: Added.
* LayoutTests/interaction-region/disabled-controls.html: Added.
Add a new test covering disabled controls.

* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
* LayoutTests/interaction-region/layer-tree-expected.txt:
Re-baseline of layer based tests.

Canonical link: https://commits.webkit.org/269625@main