[webkit-changes] [WebKit/WebKit] 605126: REGRESSION(269613 at main): `text-wrap: balance` pars...

Tim Nguyen noreply at github.com
Sat Oct 21 06:59:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60512655e7aff3095432eedf8babf923d8c30cf6
      https://github.com/WebKit/WebKit/commit/60512655e7aff3095432eedf8babf923d8c30cf6
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-10-21 (Sat, 21 Oct 2023)

  Changed paths:
    A LayoutTests/fast/css/text-wrap-style-disabled-expected.txt
    A LayoutTests/fast/css/text-wrap-style-disabled.html
    M Source/WebCore/css/parser/CSSPropertyParser.cpp

  Log Message:
  -----------
  REGRESSION(269613 at main): `text-wrap: balance` parses even when `text-wrap-style` is disabled
https://bugs.webkit.org/show_bug.cgi?id=263495
rdar://117295817

Reviewed by Alan Baradlay.

269613 at main accidentally enabled `text-wrap: balance`. It was assuming the generated `text-wrap-style` parsing function
would check for the preference, but that is not the case.

Add a manual check for the preference to avoid exposing the `text-wrap-style` values in `text-wrap` when the longhand is disabled.

* LayoutTests/fast/css/text-wrap-style-disabled-expected.txt: Added.
* LayoutTests/fast/css/text-wrap-style-disabled.html: Added.
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTextWrapShorthand):

Canonical link: https://commits.webkit.org/269624@main




More information about the webkit-changes mailing list