[webkit-changes] [WebKit/WebKit] f98a7b: Don't allow form-feed (U+000C) as a WebVTT signatu...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f98a7bee4cc3cd9f75b1e4e2f99d7414117c23d3
      https://github.com/WebKit/WebKit/commit/f98a7bee4cc3cd9f75b1e4e2f99d7414117c23d3
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt
    M Source/WebCore/html/track/WebVTTParser.cpp

  Log Message:
  -----------
  Don't allow form-feed (U+000C) as a WebVTT signature separator
https://bugs.webkit.org/show_bug.cgi?id=260390
rdar://114118340

Reviewed by Eric Carlson.

As U+000A and U+000D are already taken care of by BufferedLineReader
we can switch this isASCIIWhitespace to isTabOrSpace and thereby avoid
ignoring an incorrect U+000C.

(Note that other identifiers in WebVTT, such as "STYLE", do allow a
trailing U+000C, so we are not changing those, even though they are also
redundantly checking for U+000A and U+000D.)

* LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt:
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::hasRequiredFileIdentifier):

Canonical link: https://commits.webkit.org/269619@main