[webkit-changes] [WebKit/WebKit] 504426: [cairo] When creating a native image from pixel bu...
Carlos Garcia Campos
noreply at github.com
Fri Oct 20 22:47:06 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 504426c318618e8a85c33c0d843d84898bb9137c
https://github.com/WebKit/WebKit/commit/504426c318618e8a85c33c0d843d84898bb9137c
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2023-10-20 (Fri, 20 Oct 2023)
Changed paths:
M Source/WebCore/platform/graphics/NativeImage.h
M Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp
M Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp
Log Message:
-----------
[cairo] When creating a native image from pixel buffer the buffer should be owned by the cairo surface
https://bugs.webkit.org/show_bug.cgi?id=263440
Reviewed by Alejandro G. Castro.
It's currently owned by the NativeImage container, but the surface can
be alive after the container destruction. This patch reverts 262575 at main
and uses cairo_surface_set_user_data() instead.
* Source/WebCore/platform/graphics/NativeImage.h:
* Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:
(WebCore::GraphicsContextGL::createNativeImageFromPixelBuffer):
* Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::NativeImage::create): Deleted.
(WebCore::NativeImage::NativeImage): Deleted.
Canonical link: https://commits.webkit.org/269618@main
More information about the webkit-changes
mailing list