[webkit-changes] [WebKit/WebKit] fa36eb: Adopt more smart pointers in the Document class

Chris Dumez noreply at github.com
Thu Oct 19 21:38:41 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa36ebb5c3c7bffd7215478e377baeb89ebc86da
      https://github.com/WebKit/WebKit/commit/fa36ebb5c3c7bffd7215478e377baeb89ebc86da
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M Source/WebCore/bindings/js/ScriptController.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/fileapi/BlobURL.cpp
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/MemoryRelease.cpp
    M Source/WebCore/page/mac/PageMac.mm
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/rendering/HitTestResult.h
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderView.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/workers/service/SWClientConnection.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
    M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  -----------
  Adopt more smart pointers in the Document class
https://bugs.webkit.org/show_bug.cgi?id=263342

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/Document.cpp:
(WebCore::CallbackForContainIntrinsicSize):
(WebCore::printNavigationErrorMessage):
(WebCore::Document::configureSharedLogger):
(WebCore::Document::addToDocumentsMap):
(WebCore::Document::allDocumentsMap):
(WebCore::createCachedResourceLoader):
(WebCore::m_frameIdentifier):
(WebCore::Document::~Document):
(WebCore::Document::commonTeardown):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::childrenChanged):
(WebCore::createUpgradeCandidateElement):
(WebCore::createHTMLElementWithNameValidation):
(WebCore::Document::createCSSStyleDeclaration):
(WebCore::createFallbackHTMLElement):
(WebCore::Document::createElement):
(WebCore::Document::documentEventTimingFromNavigationTiming):
(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::setCharset):
(WebCore::Document::setDocumentElementLanguage):
(WebCore::Document::protectedParser const):
(WebCore::Document::setContent):
(WebCore::Document::contentType const):
(WebCore::Document::caretPositionFromPoint):
(WebCore::Document::scrollingElement):
(WebCore::canonicalizedTitle):
(WebCore::Document::updateTitle):
(WebCore::Document::updateTitleFromTitleElement):
(WebCore::Document::setTitle):
(WebCore::Document::protectedTitleElement const):
(WebCore::Document::updateTitleElement):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayout):
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
(WebCore::Document::isResolvingContainerQueriesForSelfOrAncestor const):
(WebCore::Document::createRenderTree):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::willDetachPage):
(WebCore::Document::attachToCachedFrame):
(WebCore::Document::protectedDocumentElement const):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::protectedUndoManager const):
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::protectedReportingScope const):
(WebCore::Document::removeAllEventListeners):
(WebCore::Document::axObjectCache const):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::createParser):
(WebCore::Document::appHighlightRegistry):
(WebCore::Document::updateHighlightPositions):
(WebCore::Document::openForBindings):
(WebCore::Document::open):
(WebCore::Document::isFullyActive const):
(WebCore::Document::detachParser):
(WebCore::Document::cancelParsing):
(WebCore::Document::implicitOpen):
(WebCore::Document::fontLoadRequest):
(WebCore::Document::beginLoadingFontSoon):
(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::explicitClose):
(WebCore::Document::implicitClose):
(WebCore::Document::setParsing):
(WebCore::Document::enqueuePaintTimingEntryIfNeeded):
(WebCore::Document::write):
(WebCore::Document::minimumDOMTimerInterval const):
(WebCore::Document::domTimerAlignmentInterval const):
(WebCore::Document::urlForBindings const):
(WebCore::Document::fallbackBaseURL const):
(WebCore::Document::processBaseElement):
(WebCore::Document::userAgent const):
(WebCore::Document::disableEval):
(WebCore::Document::disableWebAssembly):
(WebCore::Document::idbConnectionProxy):
(WebCore::Document::createRTCDataChannelRemoteHandlerConnection):
(WebCore::Document::canNavigateInternal):
(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):
(WebCore::Document::dispatchDisabledAdaptationsDidChangeForMainFrame):
(WebCore::Document::viewportArguments const):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::themeColorChanged):
(WebCore::Document::processColorScheme):
(WebCore::Document::metaElementColorSchemeChanged):
(WebCore::Document::processWebAppOrientations):
(WebCore::Document::prepareMouseEvent):
(WebCore::Document::canAcceptChild const):
(WebCore::Document::cloneNodeInternal):
(WebCore::Document::cloneDataFromDocument):
(WebCore::Document::protectedDecoder const):
(WebCore::Document::runScrollSteps):
(WebCore::Document::noteUserInteractionWithMediaElement):
(WebCore::Document::updateIsPlayingMedia):
(WebCore::Document::flushAutofocusCandidates):
(WebCore::Document::hoveredElementDidDetach):
(WebCore::Document::updateEventRegions):
(WebCore::Document::scheduleDeferredAXObjectCacheUpdate):
(WebCore::Document::flushDeferredAXObjectCacheUpdate):
(WebCore::Document::updateAccessibilityObjectRegions):
(WebCore::Document::invalidateEventRegionsForFrame):
(WebCore::Document::invalidateEventListenerRegions):
(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::protectedFocusedElement const):
(WebCore::Document::setFocusedElement):
(WebCore::Document::focusNavigationStartingNode const):
(WebCore::Document::updateRangesAfterChildrenChanged):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::parentlessNodeMovedToNewDocument):
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
(WebCore::Document::textNodeSplit):
(WebCore::Document::takeDOMWindowFrom):
(WebCore::Document::protectedContextDocument const):
(WebCore::Document::setWindowAttributeEventListener):
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
(WebCore::Document::queueTaskToDispatchEventOnWindow):
(WebCore::Document::enqueueOverflowEvent):
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
(WebCore::Document::referrerForBindings):
(WebCore::Document::shouldMaskURLForBindingsInternal const):
(WebCore::Document::setBackForwardCacheState):
(WebCore::Document::suspend):
(WebCore::Document::resume):
(WebCore::Document::requiresUserGestureForAudioPlayback const):
(WebCore::Document::requiresUserGestureForVideoPlayback const):
(WebCore::Document::mediaDataLoadsAutomatically const):
(WebCore::Document::privateBrowsingStateDidChange):
(WebCore::Document::registerForCaptionPreferencesChangedCallbacks):
(WebCore::Document::captionPreferencesChanged):
(WebCore::Document::updateTextTrackRepresentationImageIfNeeded):
(WebCore::Document::applyPendingXSLTransformsTimerFired):
(WebCore::Document::finishedParsing):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::initDNSPrefetch):
(WebCore::Document::getParserLocation const):
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::Document::postTask):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
(WebCore::Document::suspendScriptedAnimationControllerCallbacks):
(WebCore::Document::resumeScriptedAnimationControllerCallbacks):
(WebCore::Document::serviceRequestAnimationFrameCallbacks):
(WebCore::Document::serviceRequestVideoFrameCallbacks):
(WebCore::Document::exitPointerLock):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::monotonicTimestamp const):
(WebCore::Document::clearScriptedAnimationController):
(WebCore::Document::wheelEventHandlersChanged):
(WebCore::Document::didRemoveEventTargetNode):
(WebCore::Document::didAddOrRemoveMouseEventHandler):
(WebCore::Document::updateLastHandledUserGestureTimestamp):
(WebCore::Document::processingUserGestureForMedia const):
(WebCore::Document::allowsContentJavaScript const):
(WebCore::Document::convertAbsoluteToClientQuads):
(WebCore::Document::convertAbsoluteToClientRects):
(WebCore::Document::convertAbsoluteToClientRect):
(WebCore::Document::decrementActiveParserCount):
(WebCore::DocumentParserYieldToken::~DocumentParserYieldToken):
(WebCore::findNearestCommonComposedAncestor):
(WebCore::Document::updateHoverActiveState):
(WebCore::Document::ensureTemplateDocument):
(WebCore::Document::documentFragmentForInnerOuterHTML):
(WebCore::Document::deviceScaleFactor const):
(WebCore::Document::useSystemAppearance const):
(WebCore::Document::useDarkAppearance const):
(WebCore::Document::useElevatedUserInterfaceLevel const):
(WebCore::Document::compositeOperatorForBackgroundColor const):
(WebCore::Document::didAssociateFormControl):
(WebCore::Document::didAssociateFormControlsTimerFired):
(WebCore::Document::didLoadResourceSynchronously):
(WebCore::Document::ensurePlugInsInjectedScript):
(WebCore::Document::wrapCryptoKey):
(WebCore::Document::unwrapCryptoKey):
(WebCore::Document::hasFocus const):
(WebCore::Document::addPlaybackTargetPickerClient):
(WebCore::Document::removePlaybackTargetPickerClient):
(WebCore::Document::showPlaybackTargetPicker):
(WebCore::Document::playbackTargetPickerClientStateDidChange):
(WebCore::Document::shouldOpenExternalURLsPolicyToPropagate const):
(WebCore::Document::shouldEnforceHTTP09Sandbox const):
(WebCore::Document::shouldEnforceQuickLookSandbox const):
(WebCore::Document::applyQuickLookSandbox):
(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox const):
(WebCore::Document::scheduleRenderingUpdate):
(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::gatherResizeObservations):
(WebCore::Document::deliverResizeObservations):
(WebCore::Document::setHasSkippedResizeObservations):
(WebCore::Document::setDir):
(WebCore::Document::fgColor const):
(WebCore::Document::alinkColor const):
(WebCore::Document::linkColorForBindings const):
(WebCore::Document::vlinkColor const):
(WebCore::Document::logger):
(WebCore::Document::updateAnimationsAndSendEvents):
(WebCore::Document::matchingAnimations):
(WebCore::Document::hideAllPopoversUntil):
(WebCore::Document::handlePopoverLightDismiss):
(WebCore::Document::didLogMessage):
(WebCore::Document::setServiceWorkerConnection):
(WebCore::Document::updateServiceWorkerClientData):
(WebCore::Document::navigateFromServiceWorker):
(WebCore::Document::frameWasDisconnectedFromOwner):
(WebCore::Document::hitTest):
(WebCore::Document::setAsRunningUserScripts):
(WebCore::Document::setPictureInPictureElement):
(WebCore::Document::notificationClient):
(WebCore::Document::graphicsClient):
(WebCore::Document::sessionID const):
(WebCore::Document::observeForContainIntrinsicSize):
(WebCore::Document::unobserveForContainIntrinsicSize):
(WebCore::Document::resetObservationSizeForContainIntrinsicSize):
(WebCore::Document::noiseInjectionPolicy const):
(WebCore::Document::noiseInjectionHashSalt const):
(WebCore::Document::mediaKeysStorageDirectory):
(WebCore::Document::protectedWindow const):
(WebCore::Document::protectedCachedResourceLoader const):
(WebCore::Document::protectedFontSelector const):
* Source/WebCore/dom/Document.h:
(WebCore::Document::setContextDocument):
(WebCore::Document::protectedParentDocument const):
(WebCore::Document::protectedTopDocument const):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::~Node):
* Source/WebCore/fileapi/BlobURL.cpp:
(WebCore::blobOwner):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::printLayoutTreeForLiveDocuments):
* Source/WebCore/page/FrameDestructionObserver.h:
* Source/WebCore/page/FrameDestructionObserverInlines.h:
(WebCore::FrameDestructionObserver::protectedFrame const):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::Document::protectedView const):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::protectedFrame const):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/MemoryRelease.cpp:
(WebCore::releaseNoncriticalMemory):
(WebCore::releaseCriticalMemory):
* Source/WebCore/page/mac/PageMac.mm:
(WebCore::Page::platformInitialize):
* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setScrollbar):
* Source/WebCore/rendering/HitTestResult.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::printPaintOrderTreeForLiveDocuments):
(WebCore::printRenderTreeForLiveDocuments):
(WebCore::printLayerTreeForLiveDocuments):
(WebCore::printGraphicsLayerTreeForLiveDocuments):
* Source/WebCore/rendering/RenderView.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::allSVGSVGElements const):
(WebCore::Internals::numberOfLiveNodes const):
* Source/WebCore/workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::postTaskForJob):
(WebCore::postMessageToContainer):
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
(WebCore::SWClientConnection::setRegistrationLastUpdateTime):
(WebCore::SWClientConnection::setRegistrationUpdateViaCache):
(WebCore::SWClientConnection::updateBackgroundFetchRegistration):
(WebCore::updateController):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
(WebCore::SWClientConnection::clearPendingJobs):
(WebCore::SWClientConnection::registerServiceWorkerClients):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::liveDocumentURLs):

Canonical link: https://commits.webkit.org/269557@main

More information about the webkit-changes mailing list