[webkit-changes] [WebKit/WebKit] ac19d2: [WebGPU] stencilAttachmentPixelFormat is never set...

mwyrzykowski noreply at github.com
Thu Oct 19 21:35:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac19d2a124a3101488ca80831e529fc6f2543108
      https://github.com/WebKit/WebKit/commit/ac19d2a124a3101488ca80831e529fc6f2543108
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] stencilAttachmentPixelFormat is never set on the MTLDepthStencilDescriptor
https://bugs.webkit.org/show_bug.cgi?id=263382
<radar://117213772>

Reviewed by Dan Glastonbury.

Need to set MTLDepthStencilDescriptor.stencilAttachmentPixelFormat for writes
to the stencil buffer to function.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::isStencilOnlyFormat):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::isStencilOnlyFormat): Deleted.
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/269556@main




More information about the webkit-changes mailing list