[webkit-changes] [WebKit/WebKit] 1556c6: REGRESSION(267193 at main): [ Debug ] TestWebKitAPI.W...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1556c6a51e8ce89e7c49ce444f75d977809f0325
      https://github.com/WebKit/WebKit/commit/1556c6a51e8ce89e7c49ce444f75d977809f0325
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm

  Log Message:
  -----------
  REGRESSION(267193 at main): [ Debug ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturingAndCalling is a near-constant failure.
https://bugs.webkit.org/show_bug.cgi?id=262145
rdar://116083315

Reviewed by Chris Dumez.

We moved LibWebRTCCodecsProxy::createEncoder to be an async callback and updated the regular code path in LibWebRTCCodecs.
But we forgot to update the GPUProcess crash code path.
We introduce a routine that is used for both code paths.

* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::createRemoteEncoder):
(WebKit::LibWebRTCCodecs::createEncoderInternal):
(WebKit::LibWebRTCCodecs::gpuProcessConnectionDidClose):
* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

Canonical link: https://commits.webkit.org/269537@main