[webkit-changes] [WebKit/WebKit] 711e9d: Set a non-zero AAGUID for platform credentials whe...

Commit Queue noreply at github.com
Thu Oct 19 11:17:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 711e9d271fec39992f5febf9d1968fe45b1a955d
      https://github.com/WebKit/WebKit/commit/711e9d271fec39992f5febf9d1968fe45b1a955d
  Author: Pascoe <pascoe at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
    M Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h
    M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
    M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
    M Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  -----------
  Set a non-zero AAGUID for platform credentials where attestation=none
https://bugs.webkit.org/show_bug.cgi?id=261340
rdar://115125044

Reviewed by Brent Fulgham.

The other FIDO platform providers return non-zero values in
this case, making us unique by having all zeros.

This patch assigns a random, fixed, AAGUID instead.

* LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
* Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
* Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
* Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.h
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm

Canonical link: https://commits.webkit.org/269536@main




More information about the webkit-changes mailing list