[webkit-changes] [WebKit/WebKit] 8cbfc4: [WebGPU] maxBindGroupsPlusVertexBuffers limit is i...

mwyrzykowski noreply at github.com
Sun Oct 15 17:20:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cbfc4626ba239e59659e3660813fd91a7485e77
      https://github.com/WebKit/WebKit/commit/8cbfc4626ba239e59659e3660813fd91a7485e77
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-15 (Sun, 15 Oct 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm

  Log Message:
  -----------
  [WebGPU] maxBindGroupsPlusVertexBuffers limit is incorrect
https://bugs.webkit.org/show_bug.cgi?id=263147
<radar://116940919>

Reviewed by Dan Glastonbury.

The limit for maxBindGroupsPlusVertexBuffers was incorrect.

The max buffer index according to https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf
is 31 but we need one buffer for our own data, so set the limit
to 30 universally.

* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::maxBuffersPlusVertexBuffersForVertexStage const):
* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::apple3):
(WebGPU::apple4):
(WebGPU::apple5):
(WebGPU::apple6):
(WebGPU::apple7):
(WebGPU::mac2):

Canonical link: https://commits.webkit.org/269349@main




More information about the webkit-changes mailing list