[webkit-changes] [WebKit/WebKit] d2b242: [GStreamer] Make downloadbuffer limits configurable

Commit Queue noreply at github.com
Sun Oct 15 13:08:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2b242779d249bd5ccb080e50199ec38e87a2e40
      https://github.com/WebKit/WebKit/commit/d2b242779d249bd5ccb080e50199ec38e87a2e40
  Author: Marek Vasut <marex at denx.de>
  Date:   2023-10-15 (Sun, 15 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Make downloadbuffer limits configurable
https://bugs.webkit.org/show_bug.cgi?id=263166

Reviewed by Philippe Normand.

Introduce two new environment variables which control the maximum amount
of buffered data by the downloadbuffer element. This is useful in case
it is necessary to control buffering large files, way larger than the
default downloadbuffer limits. The following new variables are added:

- WPE_SHELL_MEDIA_DISK_CACHE_SIZE_BYTES ~ downloadbuffer max-size-bytes
- WPE_SHELL_MEDIA_DISK_CACHE_SIZE_NSEC ~ downloadbuffer max-size-time

Example HTML file, note esp. the 'preload="auto"' which is mandatory:
```
<video src="./file.mp4" autoplay muted loop preload="auto"></video>
```

Example invocation to cache up to 200 MiB per file and 500s per file:
```
$ WPE_SHELL_MEDIA_DISK_CACHE_SIZE_BYTES=268435456 \
  WPE_SHELL_MEDIA_DISK_CACHE_SIZE_NSEC=500000000000 \
  WEBKIT_GST_USE_PLAYBIN3=1 \
  cog http://example/index.html
```

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

Canonical link: https://commits.webkit.org/269348@main




More information about the webkit-changes mailing list