[webkit-changes] [WebKit/WebKit] 96b83e: showPicker() method of date input doesn't work

Luke Warlow noreply at github.com
Thu Oct 12 09:23:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96b83e8d4b0e7d4e8f08fc92b7723dbfa07eac8f
      https://github.com/WebKit/WebKit/commit/96b83e8d4b0e7d4e8f08fc92b7723dbfa07eac8f
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
    A LayoutTests/fast/forms/date/date-show-picker-expected.txt
    A LayoutTests/fast/forms/date/date-show-picker.html
    A LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker-expected.txt
    A LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker.html
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/BaseDateAndTimeInputType.cpp
    M Source/WebCore/html/BaseDateAndTimeInputType.h
    M Source/WebCore/html/MonthInputType.cpp
    M Source/WebCore/html/MonthInputType.h
    M Source/WebCore/html/TimeInputType.cpp
    M Source/WebCore/html/TimeInputType.h
    M Source/WebCore/html/WeekInputType.cpp
    M Source/WebCore/html/WeekInputType.h

  Log Message:
  -----------
  showPicker() method of date input doesn't work
https://bugs.webkit.org/show_bug.cgi?id=257308

Reviewed by Aditya Keerthi.

Implement showPicker for date and datetime-local inputs.

* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseDateAndTimeInputType::showPicker):
* Source/WebCore/html/BaseDateAndTimeInputType.h:
* Source/WebCore/html/MonthInputType.cpp:
(WebCore::MonthInputType::showPicker):
* Source/WebCore/html/MonthInputType.h:
* Source/WebCore/html/TimeInputType.cpp:
(WebCore::TimeInputType::showPicker):
* Source/WebCore/html/TimeInputType.h:
* Source/WebCore/html/WeekInputType.cpp:
(WebCore::WeekInputType::showPicker):
* Source/WebCore/html/WeekInputType.h:
* LayoutTests/fast/forms/date/date-show-picker-expected.txt: Added.
* LayoutTests/fast/forms/date/date-show-picker.html: Added.
* LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker-expected.txt: Added.
* LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/269257@main




More information about the webkit-changes mailing list