[webkit-changes] [WebKit/WebKit] b07a47: AVAudioSessionCaptureDeviceManager auxiliary Audio...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b07a477e1786f9dd08e8d8f4cafe818abdda05a6
      https://github.com/WebKit/WebKit/commit/b07a477e1786f9dd08e8d8f4cafe818abdda05a6
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
    R LayoutTests/fast/mediastream/enumerateDevices-active-auxiliary-unit-expected.txt
    R LayoutTests/fast/mediastream/enumerateDevices-active-auxiliary-unit.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h
    M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h
    M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm
    M Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.h
    M Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
    M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
    M Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.cpp
    M Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.h
    M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
    M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/TestInvocation.cpp
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  AVAudioSessionCaptureDeviceManager auxiliary AudioSession does not need to be activated to list devices
https://bugs.webkit.org/show_bug.cgi?id=263012
rdar://116807764

Reviewed by Eric Carlson.

On iOS 17, we no longer need the auxiliary audio session to be active to list all devices.
We can simplify the code and remove the risk of impacting the audio rendering when activating the auxiliary session.

Remove the test and corresponding WTR implementation since we are no longer activating the aux session.

* LayoutTests/fast/mediastream/enumerateDevices-active-auxiliary-unit-expected.txt: Removed.
* LayoutTests/fast/mediastream/enumerateDevices-active-auxiliary-unit.html: Removed.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h:
(WebCore::AudioCaptureFactory::addExtensiveObserver): Deleted.
(WebCore::AudioCaptureFactory::removeExtensiveObserver): Deleted.
* Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
* Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::createAudioSession):
(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):
(WebCore::AVAudioSessionCaptureDeviceManager::computeCaptureDevices):
(WebCore::AVAudioSessionCaptureDeviceManager::activateAudioSession): Deleted.
(WebCore::AVAudioSessionCaptureDeviceManager::enableAllDevicesQuery): Deleted.
(WebCore::AVAudioSessionCaptureDeviceManager::disableAllDevicesQuery): Deleted.
* Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.h:
* Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
(WebCore::CoreAudioCaptureSourceFactoryIOS::createAudioCaptureSource):
(WebCore::CoreAudioCaptureSourceFactoryIOS::addExtensiveObserver): Deleted.
(WebCore::CoreAudioCaptureSourceFactoryIOS::removeExtensiveObserver): Deleted.
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h:
* Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
* Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.cpp:
(WKUserMediaPermissionCheckSetUserMediaAccessInfo):
(WKUserMediaIsEnumeratingAudioUnitActive): Deleted.
* Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.h:
* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::invalidatePendingRequests):
(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::resetAccess):
(WebKit::UserMediaPermissionRequestManagerProxy::startProcessingUserMediaPermissionRequest):
* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::isEnumeratingAudioUnitActive const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::isDoingMediaCapture const):
(WTR::TestController::isEnumeratingAudioUnitActive const): Deleted.
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::isEnumeratingAudioUnitActive const): Deleted.

Canonical link: https://commits.webkit.org/269256@main