[webkit-changes] [WebKit/WebKit] 5965a5: AX: TextInputMarkedTextMarkerRange should be cache...

Joshua Hoffman noreply at github.com
Tue Nov 28 17:58:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5965a5a92e802141a8ec48b1a83c9bb88069f1e1
      https://github.com/WebKit/WebKit/commit/5965a5a92e802141a8ec48b1a83c9bb88069f1e1
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/text-input-marked-range-expected.txt
    M LayoutTests/accessibility/mac/text-input-marked-range.html
    M LayoutTests/accessibility/mac/text-input-marked-text-marker-range-expected.txt
    M LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

  Log Message:
  -----------
  AX: TextInputMarkedTextMarkerRange should be cached during initialization
https://bugs.webkit.org/show_bug.cgi?id=265434
rdar://problem/118866640

Reviewed by Tyler Wilcock.

When isolated objects are created for text controls, we do not cache the initial TextInputMarkedTextMarkerRange
value. This becomes an issue when an object is initialized while there is already marked text. In that case, not
caching that value initially will return a null text marker range, which is incorrect.

This patch caches that value when initializing the object, as well as updates related tests to (1) verify this
behavior and (2) retrieve that range asynchronously.

* LayoutTests/accessibility/mac/text-input-marked-range-expected.txt:
* LayoutTests/accessibility/mac/text-input-marked-range.html:
* LayoutTests/accessibility/mac/text-input-marked-text-marker-range-expected.txt:
* LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):

Canonical link: https://commits.webkit.org/271251@main




More information about the webkit-changes mailing list