[webkit-changes] [WebKit/WebKit] 230249: Remove unused ENABLE macros

Don Olmstead noreply at github.com
Tue Nov 28 17:43:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2302494878b11514807ac973c25daf25d5891f4b
      https://github.com/WebKit/WebKit/commit/2302494878b11514807ac973c25daf25d5891f4b
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformEnable.h
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WebCore/Headers.cmake
    M Source/WebKit/CMakeLists.txt
    M Source/cmake/OptionsMac.cmake
    M Source/cmake/WebKitFeatures.cmake
    M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  -----------
  Remove unused ENABLE macros
https://bugs.webkit.org/show_bug.cgi?id=265482

Reviewed by Michael Catanzaro.

Used the `find-feature-flags` script to find `ENABLE` flags that were
only present in the CMake code. Identified `ENABLE` flags that could be
removed.

`ENABLE_RUBBER_BANDING` was changed to `HAVE_RUBBER_BANDING` so all
references could be removed.

`ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER` was removed completely.

`ENABLE_OPENCDM` isn't used and looks to be represented by
`ENABLE_THUNDER`.

Finally sort the listing of `ENABLE` flags in `WebKitFeatures.cmake`.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/Headers.cmake:
* Source/WebKit/CMakeLists.txt:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/271250@main




More information about the webkit-changes mailing list