[webkit-changes] [WebKit/WebKit] b1f4d8: FontFace with data: URI crashes Worker

youennf noreply at github.com
Tue Nov 28 07:44:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1f4d8147c3c426fe7c4dcbc11dd7d7689064b6c
      https://github.com/WebKit/WebKit/commit/b1f4d8147c3c426fe7c4dcbc11dd7d7689064b6c
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    A LayoutTests/http/wpt/workers/font-loading-error.any-expected.txt
    A LayoutTests/http/wpt/workers/font-loading-error.any.html
    A LayoutTests/http/wpt/workers/font-loading-error.any.js
    A LayoutTests/http/wpt/workers/font-loading-error.any.worker-expected.txt
    A LayoutTests/http/wpt/workers/font-loading-error.any.worker.html
    M Source/WebCore/dom/DocumentFontLoader.cpp
    M Source/WebCore/workers/WorkerFontLoadRequest.cpp

  Log Message:
  -----------
  FontFace with data: URI crashes Worker
https://bugs.webkit.org/show_bug.cgi?id=265000
rdar://118546120

Reviewed by Alex Christensen.

Make sure to reject the promise when font loading fails in a worker.
Align implementation with spec on data URL font loading by allowing them.

* LayoutTests/http/wpt/workers/font-loading-error.any-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.html: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.js: Added.
(promise_test.async return):
(promise_test):
* LayoutTests/http/wpt/workers/font-loading-error.any.worker-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.worker.html: Added.
* Source/WebCore/dom/DocumentFontLoader.cpp:
(WebCore::DocumentFontLoader::cachedFont):
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:
(WebCore::WorkerFontLoadRequest::load):
(WebCore::WorkerFontLoadRequest::didFail):

Canonical link: https://commits.webkit.org/271213@main




More information about the webkit-changes mailing list