[webkit-changes] [WebKit/WebKit] 035bc1: [IFC][Intrinsic width] Introduce BoxGeometryUpdate...

Alan Baradlay noreply at github.com
Tue Nov 28 07:42:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 035bc182186de13fb27ce3254cdf4585c90fb89d
      https://github.com/WebKit/WebKit/commit/035bc182186de13fb27ce3254cdf4585c90fb89d
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.h
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [IFC][Intrinsic width] Introduce BoxGeometryUpdater::setGeometriesForIntrinsicWidth
https://bugs.webkit.org/show_bug.cgi?id=265419

Reviewed by Antti Koivisto.

This is in preparation for adding inline level box support for computing min/max content width.

1. Update the inline direction geometries when preparing for intrinsic width computation
2. Use computed (fixed) margin/border/padding values as at intrinsic width computation, the associated renderers don't yet have margin/border/padding values (this is pre-layout).

* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::fixedValueOrZero):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateListMarkerDimensions):
(WebCore::LayoutIntegration::horizontalLogicalMargin):
(WebCore::LayoutIntegration::logicalBorder):
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::setGeometriesForIntrinsicWidth):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineContentConstraints):
* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.h:
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::setHorizontalBorder):
(WebCore::Layout::BoxGeometry::setVerticalBorder):
(WebCore::Layout::BoxGeometry::setHorizontalPadding):

Canonical link: https://commits.webkit.org/271212@main




More information about the webkit-changes mailing list