[webkit-changes] [WebKit/WebKit] 250248: Path::operator== is incorrect and unused

Kimmo Kinnunen noreply at github.com
Mon Nov 27 02:21:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2502481c805f5c8a62af86eeef6794d85dc08098
      https://github.com/WebKit/WebKit/commit/2502481c805f5c8a62af86eeef6794d85dc08098
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/platform/graphics/Path.cpp
    M Source/WebCore/platform/graphics/Path.h
    M Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp

  Log Message:
  -----------
  Path::operator== is incorrect and unused
https://bugs.webkit.org/show_bug.cgi?id=265333
rdar://problem/118823083

Reviewed by Tim Nguyen.

It is not entirely trivial to compare paths for equality. The
current implementation is confusing since it returns false for equal
Paths. Remove the implementation instead of fixing since it's not used.

* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::operator== const): Deleted.
* Source/WebCore/platform/graphics/Path.h:
* Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:
(TestWebKitAPI::convertToString):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271136@main




More information about the webkit-changes mailing list