[webkit-changes] [WebKit/WebKit] 3d00b4: [GStreamer] proxy.getAvailableBuffer() can only be...

Philippe Normand noreply at github.com
Mon Nov 27 01:29:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d00b4621046e355d5bb8bf10d8657e41415a9f6
      https://github.com/WebKit/WebKit/commit/3d00b4621046e355d5bb8bf10d8657e41415a9f6
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp

  Log Message:
  -----------
  [GStreamer] proxy.getAvailableBuffer() can only be called from the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=219653

Reviewed by Xabier Rodriguez-Calvar.

When the player relies on the GL video sink the TextureMapperPlatformLayerProxyGL is used to render
frames to the compositor. In rare cases the frame holder can fail to map the GStreamer GL frame in
memory, so it needs to get a layer buffer from the TextureMapper and upload the frame contents to
it. That operation is done from the video sink streaming thread, which is different from the
compositor thread, so we can't ASSERT about this.

* Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:
(WebCore::TextureMapperPlatformLayerProxyGL::getAvailableBuffer):

Canonical link: https://commits.webkit.org/271135@main




More information about the webkit-changes mailing list