[webkit-changes] [WebKit/WebKit] a64ff9: Move `hasExplicitlySet{Direction|WritingMode}` fro...

Tim Nguyen noreply at github.com
Tue Nov 21 15:37:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a64ff93835bb7ea77d63c0b36e07ec878f8cefdf
      https://github.com/WebKit/WebKit/commit/a64ff93835bb7ea77d63c0b36e07ec878f8cefdf
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Move `hasExplicitlySet{Direction|WritingMode}` from `NonInheritedFlags` into `StyleMiscNonInheritedData`
https://bugs.webkit.org/show_bug.cgi?id=265217
rdar://118697101

Reviewed by Cameron McCormack and Timothy Hatcher.

Make room for view transitions pseudo elements.

Remove the setter argument to be consistent with `hasExplicitlySetColorScheme`.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::hasExplicitlySetDirection const): Deleted.
(WebCore::RenderStyle::setHasExplicitlySetDirection): Deleted.
(WebCore::RenderStyle::hasExplicitlySetWritingMode const): Deleted.
(WebCore::RenderStyle::setHasExplicitlySetWritingMode): Deleted.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::hasExplicitlySetDirection const):
(WebCore::RenderStyle::hasExplicitlySetWritingMode const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setHasExplicitlySetDirection):
(WebCore::RenderStyle::setHasExplicitlySetWritingMode):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp:
(WebCore::StyleMiscNonInheritedData::StyleMiscNonInheritedData):
(WebCore::StyleMiscNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueDirection):
(WebCore::Style::BuilderCustom::applyValueWritingMode):

Canonical link: https://commits.webkit.org/271029@main




More information about the webkit-changes mailing list