[webkit-changes] [WebKit/WebKit] 86db6a: Move `verticalAlign` from `NonInheritedFlags` to `...

Tim Nguyen noreply at github.com
Tue Nov 21 14:45:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86db6a29cf795a8a63cb052a2bd0be9d577ea109
      https://github.com/WebKit/WebKit/commit/86db6a29cf795a8a63cb052a2bd0be9d577ea109
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleBoxData.cpp
    M Source/WebCore/rendering/style/StyleBoxData.h

  Log Message:
  -----------
  Move `verticalAlign` from `NonInheritedFlags` to `StyleBoxData`
https://bugs.webkit.org/show_bug.cgi?id=265210
rdar://118694983

Reviewed by Cameron McCormack.

`verticalAlignLength` is already stored in `StyleBoxData`. Also move `verticalAlign` there to make room for view transition pseudo elements in `NonInheritedFlags`.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::verticalAlign const): Deleted.
(WebCore::RenderStyle::setVerticalAlign): Deleted.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::verticalAlign const):
(WebCore::RenderStyle::verticalAlignLength const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setVerticalAlign):
(WebCore::RenderStyle::setVerticalAlignLength):
* Source/WebCore/rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator== const):
* Source/WebCore/rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::verticalAlignLength const):
(WebCore::StyleBoxData::verticalAlign const):

Canonical link: https://commits.webkit.org/271028@main




More information about the webkit-changes mailing list