[webkit-changes] [WebKit/WebKit] 34925e: colorDepth returns '0' on detached frame

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34925ea7ad8031c79323a34e6b93b03a5e83e1d0
      https://github.com/WebKit/WebKit/commit/34925ea7ad8031c79323a34e6b93b03a5e83e1d0
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M LayoutTests/http/tests/dom/same-origin-detached-window-properties-expected.txt
    M LayoutTests/http/tests/dom/same-origin-detached-window-properties.html
    M LayoutTests/imported/w3c/resources/resource-files.json
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/screen-detached-frame-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/screen-detached-frame.html
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/w3c-import.log
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change.html
    M Source/WebCore/page/Screen.cpp

  Log Message:
  -----------
  colorDepth returns '0' on detached frame
https://bugs.webkit.org/show_bug.cgi?id=265021

Reviewed by Simon Fraser.

The specification requires 24 as a fallback rather than 0:
https://drafts.csswg.org/cssom-view/#dom-screen-colordepth

Always returning 24 is tempting, but maybe not correct long term.

This synchronizes web-platforms-tests for css/cssom-view with:
https://github.com/web-platform-tests/wpt/commit/46476776fdbf0a62522621002ba8af68e4d478b6

* LayoutTests/http/tests/dom/same-origin-detached-window-properties-expected.txt:
* LayoutTests/http/tests/dom/same-origin-detached-window-properties.html:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/screen-detached-frame-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/screen-detached-frame.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/window-scrollBy-display-change.html: Added.
* Source/WebCore/page/Screen.cpp:
(WebCore::Screen::colorDepth const):

Canonical link: https://commits.webkit.org/270952@main