[webkit-changes] [WebKit/WebKit] 74ae3e: Don't fire dblclick on disabled form control elements

Ahmad Saleem noreply at github.com
Sun Nov 19 09:12:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74ae3ea8d68e6bc52dc58bae5064a8ec4e2e09ae
      https://github.com/WebKit/WebKit/commit/74ae3ea8d68e6bc52dc58bae5064a8ec4e2e09ae
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt
    M LayoutTests/platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt
    M Source/WebCore/dom/EventDispatcher.cpp

  Log Message:
  -----------
  Don't fire dblclick on disabled form control elements

https://bugs.webkit.org/show_bug.cgi?id=265071
rdar://problem/118584431

Reviewed by Tim Nguyen.

This patch extends to not fire double click events on disabled elements similar to click event aligning with
Gecko / Firefox, Blink / Chromium and agreed behavior in web specification issue [1]:

[1] https://github.com/whatwg/html/issues/2368#issuecomment-1791704780

* Source/WebCore/dom/EventDispatcher.cpp:
(EventDispatcher::dispatchEvent):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined
* LayoutTests/platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/270951@main




More information about the webkit-changes mailing list