[webkit-changes] [WebKit/WebKit] edb411: [WebGPU] copy compressed textures fails when textu...

mwyrzykowski noreply at github.com
Fri Nov 17 04:26:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edb411c919576af5b884c4edc7c44080bd78d7ca
      https://github.com/WebKit/WebKit/commit/edb411c919576af5b884c4edc7c44080bd78d7ca
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture-expected.txt
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] copy compressed textures fails when texture width is not divisible by the block size
https://bugs.webkit.org/show_bug.cgi?id=264923
radar://118491364

Reviewed by Tadeu Zagallo.

To correctly write to compressed textures, the width of the data must be divisible
by the compressed texture's block size and we were not previously ensuring that.

Also clean up newBytesPerRow and levelInfoBytesPerRow duplication which were being
assigned the same value and never modified.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture-expected.txt:
Add test expectation as this passes locally.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):

Canonical link: https://commits.webkit.org/270881@main




More information about the webkit-changes mailing list